Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross compile error #2758

Closed
wants to merge 2 commits into from
Closed

Fix cross compile error #2758

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5d16f7
Fix cross compile error
walkerlee Sep 9, 2015
10a2591
Add missing close parenthesis
walkerlee Sep 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,7 @@ def configure_library(lib, output):
# libpath needs to be provided ahead libraries
if pkg_libpath:
output['libraries'] += (
filter(None, map(str.strip, pkg_cflags.split('-L'))))
map('-L{0}'.format, filter(None, map(str.strip, pkg_libpath.split('-L')))))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walkerlee isn't this code just removing '-L' from each library and then adding it back at the end?

Would the appropriate course of action not be just to split pkg_libpath on whitespace?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace isn't safe -- /foo/my files/. Output from pkg_config should avoid being parsed if possible.


default_libs = getattr(options, shared_lib + '_libname')
default_libs = map('-l{0}'.format, default_libs.split(','))
Expand Down