Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary semicolons after macros #27529

Closed
wants to merge 1 commit into from
Closed

Remove unnecessary semicolons after macros #27529

wants to merge 1 commit into from

Conversation

hashseed
Copy link
Member

@hashseed hashseed commented May 2, 2019

These do not play well with -Wextra-semi

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@hashseed
Remove unnecessary semicolons after macros
1f7f06e 
These do not play well with -Wextra-semi
@hashseed hashseed requested a review from joyeecheung May 2, 2019 09:06
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3424

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 2, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 3, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 3, 2019 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/22937/ ✅

@ZYSzys
Copy link
Member

ZYSzys commented May 4, 2019

Landed in 96c7892

@ZYSzys ZYSzys closed this May 4, 2019
ZYSzys pushed a commit that referenced this pull request May 4, 2019
@hashseed @ZYSzys
src: remove unnecessary semicolons after macros
96c7892 
These do not play well with -Wextra-semi

PR-URL: #27529
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request May 5, 2019
@hashseed @targos
src: remove unnecessary semicolons after macros
bb373d0 
These do not play well with -Wextra-semi

PR-URL: #27529
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hashseed @nodejs-github-bot @ZYSzys @Trott @addaleax @benjamingr @BridgeAR