Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add "mustCall" to test-fs-readfile-unlink #27453

Closed
wants to merge 1 commit into from
Closed

test: add "mustCall" to test-fs-readfile-unlink #27453

wants to merge 1 commit into from

Conversation

ckthewu
Copy link

@ckthewu ckthewu commented Apr 28, 2019

Add common.mustCall to test-fs-readfile-unlink

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

test: add "mustCall" to test-fs-readfile-unlink
f29717a 
Add common.mustCall to test-fs-readfile-unlink
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 28, 2019
@joyeecheung joyeecheung added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Apr 28, 2019
@gireeshpunathil
Copy link
Member

please leave 👍 to fast track

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22775/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22807/

@starkwang
Copy link
Contributor

Landed in 413256d

@starkwang starkwang closed this Apr 29, 2019
starkwang pushed a commit that referenced this pull request Apr 29, 2019
@starkwang
test: add "mustCall" to test-fs-readfile-unlink
413256d 
Add common.mustCall to test-fs-readfile-unlink

PR-URL: #27453
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Apr 29, 2019
@targos
test: add "mustCall" to test-fs-readfile-unlink
c1b0465 
Add common.mustCall to test-fs-readfile-unlink

PR-URL: #27453
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ckthewu @gireeshpunathil @nodejs-github-bot @starkwang @cjihrig @joyeecheung @ZYSzys