doc: add missing pull request number #27336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
tniessen
approved these changes
Apr 21, 2019
vsemozhetbyt
approved these changes
Apr 21, 2019
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
added
the
author ready
addaleax
approved these changes
Apr 21, 2019
4 tasks
|
This PR seems to add a lot more than just a PR number? |
|
@mscdex I had to force push to master to fix a test and I did not yet update this PR (see the note about the force push). It's only about the second commit. |
BridgeAR
force-pushed
the
fix-changes-entry
branch
from
421ee25 to
74adb9a
Compare
mihalskiy
approved these changes
Apr 22, 2019
benjamingr
approved these changes
Apr 22, 2019
lpinca
approved these changes
Apr 23, 2019
|
@BridgeAR Seems that there are some conflicts need to be resolved. |
This adds a missing pull request number to the `repl.md`.
BridgeAR
force-pushed
the
fix-changes-entry
branch
from
74adb9a to
ff0f181
Compare
ZYSzys
approved these changes
Apr 24, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 24, 2019
This fixes a pull request number in `repl.md`. PR-URL: nodejs#27336 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
|
Landed in 237d9f9 🎉 (I updated the description while landing since the PR number was actually set to a falsy value in the meanwhile). |
targos
pushed a commit
that referenced
this pull request
Apr 27, 2019
This fixes a pull request number in `repl.md`. PR-URL: #27336 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a missing pull request number to the
repl.md.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes