-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: simplify nomination process text #27317
Conversation
In GOVERNANCE.md, simplify the text describing Collaborator nominations.
GOVERNANCE.md
Outdated
The nomination must be approved by the TSC, which is assumed when there are no | ||
objections from any TSC members. | ||
The nomination passes if no Collaborators oppose it after one week. If a | ||
Collaborator opposes the nomination, the TSC may still choose to approve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that this has happened before, but I don't think the TSC usually insists on approving a nomination even though there is objection (or it should) , so this somewhat changes the actual meaning of the passage?
What I have in mind when I read this is more like:
If a Collaborator opposes the nomination, the TSC must try to resolve the disagreement.
If the disagreement cannot be resolved within <insert time>, the nomination fails.
The difference is that the resolution process does not exclude non-TSC collaborators (or the nominee).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely see what you're saying, @joyeecheung. My intention was to remove the whole thing about the TSC being responsible for facilitating anything. While the TSC could choose to do that, I'm not sure it is terribly relevant or accurate to say that they are responsible for it. Moreover, such actions are far more likely to be taken by individual TSC members independently than by the TSC as a whole. Lastly, as you point out, this has literally never come up.
The whole "TSC can override the objection" thing wasn't supposed to be new material, but I see that I was reading too much into the text. So I've removed it. PTAL!
@benjamingr I've removed one significant sentence since your approval. Might be a good idea to check again to make sure your approval still stands? |
Landed in 72308a5 |
In GOVERNANCE.md, simplify the text describing Collaborator nominations. PR-URL: nodejs#27317 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
In GOVERNANCE.md, simplify the text describing Collaborator nominations.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes