Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix comma splice in Assertion Testing doc #2728

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 7, 2015

Minor typo fix. /cc @nodejs/documentation

@Trott
Copy link
Member Author

Trott commented Sep 7, 2015

CI: https://ci.nodejs.org/job/node-test-pull-request/264/

Didn't see an obvious "documentation only" checkbox so went with the full CI.

@cjihrig
Copy link
Contributor

cjihrig commented Sep 7, 2015

LGTM

1 similar comment
@targos
Copy link
Member

targos commented Sep 7, 2015

LGTM

@mscdex mscdex added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Sep 7, 2015
@jbergstroem
Copy link
Member

LGTM

@Trott afaik the setting to merge docs only doesn't exist for node-test-pr, only the merge counterpart. Perhaps worth adding.

Trott added a commit that referenced this pull request Sep 8, 2015
This fixes a minor typographical error in the Assertion Testing doc.

PR-URL: #2728
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
@Trott
Copy link
Member Author

Trott commented Sep 8, 2015

Landed in 8f87169

@Trott Trott closed this Sep 8, 2015
Trott added a commit that referenced this pull request Sep 8, 2015
This fixes a minor typographical error in the Assertion Testing doc.

PR-URL: #2728
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Trott added a commit that referenced this pull request Sep 12, 2015
This fixes a minor typographical error in the Assertion Testing doc.

PR-URL: #2728
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
@rvagg rvagg mentioned this pull request Sep 12, 2015
@Fishrock123 Fishrock123 mentioned this pull request Sep 13, 2015
7 tasks
@rvagg rvagg mentioned this pull request Sep 22, 2015
@Trott Trott deleted the doc-assert-minor branch January 9, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants