Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add ability to skip common flag checks #27254

Closed
wants to merge 2 commits into from
Closed

test: add ability to skip common flag checks #27254

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54e21fc
test: add ability to skip common flag checks
addaleax Apr 16, 2019
f0ba962
fixup! test: add ability to skip common flag checks
addaleax Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ const hasCrypto = Boolean(process.versions.openssl);
// If the binary was built without-ssl then the crypto flags are
// invalid (bad option). The test itself should handle this case.
if (process.argv.length === 2 &&
!process.env.NODE_SKIP_FLAG_CHECK &&
BridgeAR marked this conversation as resolved.
Show resolved Hide resolved
isMainThread &&
hasCrypto &&
module.parent &&
Expand Down Expand Up @@ -82,7 +83,8 @@ if (process.argv.length === 2 &&
(process.features.inspector || !flag.startsWith('--inspect'))) {
console.log(
'NOTE: The test started as a child_process using these flags:',
util.inspect(flags)
util.inspect(flags),
'Use NODE_SKIP_FLAG_CHECK to run the test with the original flags.'
);
const args = [...flags, ...process.execArgv, ...process.argv.slice(1)];
const options = { encoding: 'utf8', stdio: 'inherit' };
Expand Down