Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: improve coverage #27230

Closed
wants to merge 1 commit into from
Closed

worker: improve coverage #27230

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This improves the worker coverage by using internal/assert instead
of relying on assert in case a faulty worker message type is
received (AFAIK this is only set internally, if it's public, this should be replaced with a test).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
worker: improve coverage
0c28437 
This improves the worker coverage by using `internal/assert` instead
of relying on `assert` in case a faulty worker message type is
received.
@BridgeAR BridgeAR requested a review from addaleax April 14, 2019 21:15
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3251

addaleax
addaleax approved these changes Apr 14, 2019
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is purely internal 👍

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22438/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22443/

@ZYSzys ZYSzys added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support. labels Apr 15, 2019
mhdawson
mhdawson approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZYSzys
Copy link
Member

ZYSzys commented Apr 17, 2019

Landed in d070f5d 🎉

@ZYSzys ZYSzys closed this Apr 17, 2019
ZYSzys pushed a commit that referenced this pull request Apr 17, 2019
@BridgeAR @ZYSzys
worker: improve coverage
d070f5d 
This improves the worker coverage by using `internal/assert` instead
of relying on `assert` in case a faulty worker message type is
received.

PR-URL: #27230
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@BridgeAR BridgeAR deleted the improve-worker-coverage branch January 20, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BridgeAR @nodejs-github-bot @ZYSzys @jasnell @addaleax @richardlau @mhdawson