Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove hyphen in TAP result #2718

Closed
wants to merge 1 commit into from

Conversation

thefourtheye
Copy link
Contributor

As it is, the TAP result shows an extra hyphen in front of test names.
Sample:
ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/454/tapResults/
This patch removes the extra hyphen.

R = @jbergstroem ?

@thefourtheye thefourtheye added the tools Issues and PRs related to the tools directory. label Sep 7, 2015
@jbergstroem
Copy link
Member

Edit: LGTM after below nit.

commit message: s/hypen/hyphen/

As it is, the TAP result shows an extra hyphen in front of test names.
Sample:
ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/454/tapResults/
This patch removes the extra hyphen.
@thefourtheye
Copy link
Contributor Author

@jbergstroem he he he. Done. Thanks for pointing out :D

@thefourtheye thefourtheye changed the title tools: remove hypen in TAP result tools: remove hyphen in TAP result Sep 7, 2015
thefourtheye added a commit that referenced this pull request Sep 12, 2015
As it is, the TAP result shows an extra hyphen in front of test names.
Sample:
ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/454/tapResults/
This patch removes the extra hyphen.

PR-URL: #2718
Reviewed-By: Johan Bergström <[email protected]>
@thefourtheye
Copy link
Contributor Author

Thanks for the review @jbergstroem :-) Landed in de05175

@thefourtheye thefourtheye deleted the fix-tap-format branch September 12, 2015 05:24
@Fishrock123 Fishrock123 mentioned this pull request Sep 13, 2015
7 tasks
thefourtheye added a commit that referenced this pull request Sep 15, 2015
As it is, the TAP result shows an extra hyphen in front of test names.
Sample:
ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/454/tapResults/
This patch removes the extra hyphen.

PR-URL: #2718
Reviewed-By: Johan Bergström <[email protected]>
thefourtheye added a commit that referenced this pull request Sep 15, 2015
As it is, the TAP result shows an extra hyphen in front of test names.
Sample:
ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/454/tapResults/
This patch removes the extra hyphen.

PR-URL: #2718
Reviewed-By: Johan Bergström <[email protected]>
@rvagg rvagg mentioned this pull request Sep 15, 2015
@rvagg rvagg mentioned this pull request Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants