src: fix process.platform
#271
Conversation
| #endif | ||
| READONLY_PROPERTY(process, "platform", platform); | ||
| READONLY_PROPERTY(process, "platform", | ||
| OneByteString(env->isolate(), NODE_PLATFORM)); |
There was a problem hiding this comment.
Style: indentation is off here.
There was a problem hiding this comment.
@bnoordhuis what is the preferred way? Like this: https://github.com/iojs/io.js/blob/v1.x/src/node.cc#L2655 or like this https://github.com/iojs/io.js/blob/v1.x/src/node.cc#L2666 ?
There was a problem hiding this comment.
The former is the preferred style. The latter is for when the former would exceed 80 columns.
e1fe270 introduces NODE_PLATFORM macro which had to be redefined in node.gyp for `process.platform` to return expected values.
vkurchatkin
force-pushed
the
fix-platform
branch
from
66cc909
to
6bbdde8
Compare
|
LGTM. I'll let @piscisaureus sign off on it and land it. |
|
@vkurchatkin And thanks, of course! :-) |
e1fe270 introduces the NODE_PLATFORM macro which had to be redefined in node.gyp for `process.platform` to return expected values. PR-URL: #271 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Bert Belder <[email protected]>
|
It was kind of a dumb mistake of me to assume that windows would be the only platform where the node platform was different from the gyp Thanks @vkurchatkin for fixing this! Landed in 9f45799. |
e1fe270 introduces NODE_PLATFORM macro which had to be redefined in node.gyp for
process.platformto return expected values.Not sure about win and solaris (can't test), but for OS X
process.platformreturnedmacinstead ofdarwinand broke some tests./cc @piscisaureus