Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: add PUT,TRACE methods to support #2703

Closed
wants to merge 1 commit into from
Closed

http: add PUT,TRACE methods to support #2703

wants to merge 1 commit into from

Conversation

JungMinu
Copy link
Member

@JungMinu JungMinu commented Sep 5, 2015

There are two more http methods to support: PUT,TRACE
Add put, trace methods to support

There are two more http methods to support: PUT,TRACE
Add put, trace methods to support
@yorkie
Copy link
Contributor

yorkie commented Sep 5, 2015

Guess this should be disable

@JungMinu
Copy link
Member Author

JungMinu commented Sep 5, 2015

@yorkie Can I ask you please explain why?

@yorkie
Copy link
Contributor

yorkie commented Sep 5, 2015

No worries, I found the following line is (just curious which feature do they support?)

self.useChunkedEncodingByDefault = false;

@thefourtheye thefourtheye added the http Issues or PRs related to the http subsystem. label Sep 5, 2015
@JungMinu JungMinu changed the title _http_client: add PUT,TRACE methods to support http: add PUT,TRACE methods to support Sep 5, 2015
@ChALkeR
Copy link
Member

ChALkeR commented Sep 5, 2015

Could you provide a testcase that this change fixes?

@JungMinu
Copy link
Member Author

JungMinu commented Sep 5, 2015

@ChALkeR Rather than fixing, this PR provides additional cases for PUT, TRACE methods

@ChALkeR
Copy link
Member

ChALkeR commented Sep 5, 2015

@JungMinu Are you sure that they were broken/unsupported without this pull request? If yes, please provide a testcase. If no, I see no point in this PR.

@targos
Copy link
Member

targos commented Sep 5, 2015

@JungMinu This change is not trivial. It needs to be tested. There is already a test for this code path added in the following commit: aef0960.
Looking at it, I think it should fail here because the PUT method is expected to use chunked encoding by default.

What is your reasoning for changing the value of useChunkedEncodingByDefault for PUT and TRACE?

@JungMinu
Copy link
Member Author

JungMinu commented Sep 5, 2015

@targos @ChALkeR Sorry, It was a mistake!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants