Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: check uv_fs_close() return value #26967

Merged
merged 1 commit into from
Mar 31, 2019
Merged

src: check uv_fs_close() return value #26967

merged 1 commit into from
Mar 31, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 28, 2019

Coverity was complaining about not checking the return value.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 28, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 28, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21997/

EDIT(cjihrig): CI was yellow.

Coverity was complaining about not checking the return value.

PR-URL: nodejs#26967
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants