Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix warning on mismatched fn signature #26950

Closed

Conversation

sam-github
Copy link
Contributor

Add the missing void* priv to node_report's Initialize().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@sam-github Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report. labels Mar 27, 2019
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2019
Add the missing `void* priv` to node_report's Initialize().
@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member

targos commented Mar 30, 2019

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 30, 2019

@danbev
Copy link
Contributor

danbev commented Apr 1, 2019

Landed in 66b9536.

@danbev danbev closed this Apr 1, 2019
danbev pushed a commit that referenced this pull request Apr 1, 2019
Add the missing `void* priv` to node_report's Initialize().

PR-URL: #26950
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
Add the missing `void* priv` to node_report's Initialize().

PR-URL: #26950
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@sam-github sam-github deleted the fix-node-report-missing-priv branch April 8, 2019 22:57
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
Add the missing `void* priv` to node_report's Initialize().

PR-URL: #26950
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Signed-off-by: Beth Griggs <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
Add the missing `void* priv` to node_report's Initialize().

PR-URL: #26950
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Signed-off-by: Beth Griggs <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants