Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: minor edit to worker_threads.md #26870

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 22, 2019

Change "JS code" to "JavaScript".

(I feel like I proposed this once before and it got rejected. If so, sorry to bring it up again!)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 22, 2019
@Trott Trott requested a review from addaleax March 22, 2019 21:41
Change "JS code" to "JavaScript".
@vsemozhetbyt vsemozhetbyt added the worker Issues and PRs related to Worker support. label Mar 22, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 23, 2019
@Trott
Copy link
Member Author

Trott commented Mar 24, 2019

Landed in 1ac88f4

@Trott Trott closed this Mar 24, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 24, 2019
Change "JS code" to "JavaScript".

PR-URL: nodejs#26870
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
Change "JS code" to "JavaScript".

PR-URL: nodejs#26870
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
Change "JS code" to "JavaScript".

PR-URL: #26870
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott Trott deleted the js-javascript branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants