Fix pummel tls test #26865
Closed
Fix pummel tls test #26865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test does not work with TLS 1.3 nor should it. Force TLS version 1.2. While at it, some refactoring: * refresh the tmp directory in case it doesn't exist! * add an assert.strictEqual() check on the client return `code` value which must be zero * use arrow functions for callbacks * add trailing commas for multiline arrays/objects Fixes: nodejs#26839
Move test-tls-session-timeout from pummel to sequential. It isn't very pummel-y and this will result in it being run on our CI more than once a day. (It broke recently and it would have been caught if it was in sequential rather than pummel.) It must be in sequential rather than pummel because it uses `common.PORT` which can result in test failures if more than one test uses it at one time in parallel.
|
@nodejs/crypto especially @sam-github |
|
If CI is green, I'd like to propose fast-tracking this. 👍 here if you are a Collaborator and believe it should be fast-tracked (to unbreak nightly CI). |
richardlau
approved these changes
Mar 22, 2019
Trott
added
the
author ready
|
I'm not sure why the s_client doesn't work with TLSv1.3, at least with those options. I'll add it to my list of things to look at. The dependence on two connections being made within In the short-term, doing this is an improvement over not having the test. |
sam-github
approved these changes
Mar 22, 2019
cjihrig
approved these changes
Mar 22, 2019
|
Landed in 6e9551e...7d201c4 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 22, 2019
The test does not work with TLS 1.3 nor should it. Force TLS version 1.2. While at it, some refactoring: * refresh the tmp directory in case it doesn't exist! * add an assert.strictEqual() check on the client return `code` value which must be zero * use arrow functions for callbacks * add trailing commas for multiline arrays/objects Fixes: nodejs#26839 PR-URL: nodejs#26865 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 22, 2019
Move test-tls-session-timeout from pummel to sequential. It isn't very pummel-y and this will result in it being run on our CI more than once a day. (It broke recently and it would have been caught if it was in sequential rather than pummel.) It must be in sequential rather than pummel because it uses `common.PORT` which can result in test failures if more than one test uses it at one time in parallel. PR-URL: nodejs#26865 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
The test does not work with TLS 1.3 nor should it. Force TLS version 1.2. While at it, some refactoring: * refresh the tmp directory in case it doesn't exist! * add an assert.strictEqual() check on the client return `code` value which must be zero * use arrow functions for callbacks * add trailing commas for multiline arrays/objects Fixes: nodejs#26839 PR-URL: nodejs#26865 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Move test-tls-session-timeout from pummel to sequential. It isn't very pummel-y and this will result in it being run on our CI more than once a day. (It broke recently and it would have been caught if it was in sequential rather than pummel.) It must be in sequential rather than pummel because it uses `common.PORT` which can result in test failures if more than one test uses it at one time in parallel. PR-URL: nodejs#26865 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
The test does not work with TLS 1.3 nor should it. Force TLS version 1.2. While at it, some refactoring: * refresh the tmp directory in case it doesn't exist! * add an assert.strictEqual() check on the client return `code` value which must be zero * use arrow functions for callbacks * add trailing commas for multiline arrays/objects Fixes: #26839 PR-URL: #26865 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Move test-tls-session-timeout from pummel to sequential. It isn't very pummel-y and this will result in it being run on our CI more than once a day. (It broke recently and it would have been caught if it was in sequential rather than pummel.) It must be in sequential rather than pummel because it uses `common.PORT` which can result in test failures if more than one test uses it at one time in parallel. PR-URL: #26865 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes