module: remove usage of require('util') cjs/loader.js
#26802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dnlup
force-pushed
the
util_internal_modules_cjs_loader
branch
from
c185339
to
eb63e45
Compare
dnlup
changed the title
cjs/loader.js
jasnell
reviewed
Mar 21, 2019
lib/internal/modules/cjs/loader.js
Outdated
| @@ -23,7 +23,7 @@ | |||
|
|
|||
| const { NativeModule } = require('internal/bootstrap/loaders'); | |||
| const { pathToFileURL } = require('internal/url'); | |||
| const util = require('util'); | |||
| const deprecate = require('internal/util').deprecate; | |||
There was a problem hiding this comment.
Suggested change
| const deprecate = require('internal/util').deprecate; | |
| const { deprecate } = require('internal/util'); |
jasnell
approved these changes
Mar 21, 2019
Use `require('internal/util').deprecate` instead of
`require('util').deprecate` in `lib/internal/modules/cjs/loader.js`.
Refs: nodejs#26546
dnlup
force-pushed
the
util_internal_modules_cjs_loader
branch
from
eb63e45
to
88c969b
Compare
BridgeAR
approved these changes
Mar 22, 2019
BridgeAR
added
the
author ready
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 24, 2019
Use `require('internal/util').deprecate` instead of
`require('util').deprecate` in `lib/internal/modules/cjs/loader.js`.
PR-URL: nodejs#26802
Refs: nodejs#26546
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in 005528a 🎉 I moved the argument in the same line as the other arguments while landing, now that the line is not above 80 characters anymore. |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Use `require('internal/util').deprecate` instead of
`require('util').deprecate` in `lib/internal/modules/cjs/loader.js`.
PR-URL: nodejs#26802
Refs: nodejs#26546
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Use `require('internal/util').deprecate` instead of
`require('util').deprecate` in `lib/internal/modules/cjs/loader.js`.
PR-URL: #26802
Refs: #26546
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
require('internal/util').deprecateinstead ofrequire('util').deprecateinlib/internal/modules/cjs/loader.js.Refs: #26546
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes