lib: lazy load v8 in error-serdes
#26689
Conversation
This comment has been minimized.
This comment has been minimized.
Lazy loading `v8` in `lib/internal/error-serdes.js` reduces the number of loaded modules by the bootstrap code for Worker threads by seven. Refs: nodejs#26501 (comment)
|
The code LGTM, but it might be worth pointing out that once we have snapshot support, we want as many modules loaded during bootstrap as possible, as opposed to as few as possible. |
I have no objections to closing this if it's not worth it. |
|
@addaleax I would like to experiment with the snapshots as soon as we fully implement them in a way to see what's best. If I am not mistaken we could still have a code cache for the lazy loaded modules which could be a good middle ground for all users. |
BridgeAR
added
the
author ready
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21588/ (✔️) |
|
Landed in 927f29d. |
Lazy loading `v8` in `lib/internal/error-serdes.js` reduces the number of loaded modules by the bootstrap code for Worker threads by seven. PR-URL: nodejs#26689 Refs: nodejs#26501 (comment) Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Lazy loading `v8` in `lib/internal/error-serdes.js` reduces the number of loaded modules by the bootstrap code for Worker threads by seven. PR-URL: #26689 Refs: #26501 (comment) Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Lazy loading
v8inlib/internal/error-serdes.jsreduces the numberof loaded modules by the bootstrap code for Worker threads by seven.
Refs: #26501 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes