-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected]: update to latest stable #266
Conversation
👌 |
PR-URL: #266 Reviewed-By: Ben Noordhuis <[email protected]>
Thanks Forrest, landed in e79ccee with a slightly reworded commit log (one that conforms to what seems to be the statistically most significant commit template; it's pretty much all over the place, though.) As to automatically upgrading: the rule is that at least one committer has to sign off on every change. If you can set up a cron job or something that automatically files a PR every week, that's fine by me. If you want something more advanced, @rvagg is probably the person you should talk to. |
Shouldn't we do this sorta as part of a release thing? |
@Fishrock123 yes we should, but it also needs to be properly tested prior to release where the actual release process is about taking a specific commit and releasing on that, not adding additional stuff to the codebase (except for turning on a boolean in node_version.h). @othiym23 the Makefile is the place for some code that can at least semi-automate this process, a |
@rvagg Starting with your last point first, a few months back I put together a probably overcomplicated patch to the If you want an |
Thank you, @bnoordhuis! |
@othiym23 ok, if the existing thing in the Makefile is from you then that's fine my me. Re bootstrap environment, don't count on a system installed npm or even node, it should be relatively self-contained with basic Unix tools (even the tests use some Unix tools like A lot of these tooling tasks in the Makefile use Python to get the job done, it'll be safest to make the same assumption; that Python is there and aside from that it's just some basic Unix tools. If it can be as simple as the |
That script
I won't be able to get to this pre-io.js 1.0.0 (because that's totally going to be released on @indutny's birthday, right?) but I'll try to set aside some time for this in the next month or so. |
Also, sounds like some mixture of Python and bootstrapping the built-in npm / iojs binaries is the way to go. (Just to make a note to myself -- anybody has a better idea, I'm all ears.) |
if all goes well then the it'll be released on the global "13th", but after a TC meeting which will flip @indutny into the 14th I think so it'll be a little bit delayed for his birthday! |
Updated by using
npm install [email protected]
to a staging directory, then copying that intodeps/npm
. See #252 for context. I would love to see a job automatically copyingnpm@latest
into the tree on a weekly basis, and if there's a way I can help make this happen, please let me know.