Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change 2018 to 2019 for 10.15.3 entry #26584

Closed
wants to merge 1 commit into from
Closed

Conversation

cprince
Copy link
Contributor

@cprince cprince commented Mar 11, 2019

The most minor of changes, a typo in the Changelog!

This is the first time I've looked at the node changelog and, because of the typo, I thought I was in the wrong place. Hope this helps!

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 11, 2019
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2019
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 11, 2019
vsemozhetbyt pushed a commit that referenced this pull request Mar 11, 2019
Most minor, 2018 should be 2019 for 10.15.3

PR-URL: #26584
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Mar 11, 2019

Landed in 06879aa
Thank you!

@BridgeAR
Copy link
Member

This does not land cleanly on v11. It seems like no v10 changelog has landed on v11 since v10.12.0? @nodejs/releasers to me this seems like a mistake?

@targos
Copy link
Member

targos commented Mar 13, 2019

No, this is normal. We don't backport release commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants