Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: refactor timer callback initialization #26583

Closed
wants to merge 3 commits into from
Closed

timers: refactor timer callback initialization #26583

wants to merge 3 commits into from

Commits on Mar 18, 2019

  1. timers: refactor to use module.exports

    @joyeecheung
    joyeecheung committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    a53dc0b View commit details
    Browse the repository at this point in the history

  2. timers: reduce usage of public util 

    Refs: nodejs#26546
    @joyeecheung
    joyeecheung committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    4ac4f32 View commit details
    Browse the repository at this point in the history

  3. timers: refactor timer callback initialization 

    This patch:

- Moves the timer callback initialization into bootstrap/node.js,
  documents when they will be called, and make the dependency on
  process._tickCallback explicit.
- Moves the initialization of tick callbacks and timer callbacks
  to the end of the bootstrap to make sure the operations
  done before those initializations are synchronous.
- Moves more internals into internal/timers.js from timers.js.
    @joyeecheung
    joyeecheung committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    4bc8ffa View commit details
    Browse the repository at this point in the history