Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embedding: refactor NewIsolate() #26525

Closed
wants to merge 6 commits into from
Closed

embedding: refactor NewIsolate() #26525

wants to merge 6 commits into from

Commits on Mar 8, 2019

  1. embedding: refactor public ArrayBufferAllocator API 

    Use a RAII approach by default, and make it possible for embedders
to use the `ArrayBufferAllocator` directly as a V8
`ArrayBuffer::Allocator`, e.g. when passing to `Isolate::CreateParams`
manually.
    @addaleax
    addaleax committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    0a24ee1 View commit details
    Browse the repository at this point in the history

  2. embedding: make NewIsolate() API more flexible 

    Split the API up into its essential parts, namely setting up
the creation parameters for the Isolate, creating it, and performing
Node.js-specific customization afterwards.
    @addaleax
    addaleax committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    8a0ff6c View commit details
    Browse the repository at this point in the history

  3. fixup! embedding: refactor public ArrayBufferAllocator API

    @addaleax
    addaleax committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    ff05c1a View commit details
    Browse the repository at this point in the history

  4. fixup! embedding: make NewIsolate() API more flexible

    @addaleax
    addaleax committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    0f26254 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2019

  1. fixup! embedding: make NewIsolate() API more flexible

    @addaleax
    addaleax committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    45e1f65 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. fixup! embedding: refactor public ArrayBufferAllocator API

    @addaleax
    addaleax committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    30d1e83 View commit details
    Browse the repository at this point in the history