Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: cleanup in all return paths in node::Start #26471

Merged
merged 1 commit into from
Mar 8, 2019
Merged

src: cleanup in all return paths in node::Start #26471

merged 1 commit into from
Mar 8, 2019

Commits on Mar 8, 2019

  1. src: cleanup in all return paths in node::Start 

    `node::Start` creates a number of artifacts in its scope which are
cleaned up in the exit path, but there is at least one path where the
cleanups are bypassed. Force all paths follow the exit sequence.

Refs: nodejs#21283
PR-URL: nodejs#26471
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
    @gireeshpunathil
    gireeshpunathil committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    e029bc9 View commit details
    Browse the repository at this point in the history