Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix test.py --shell #26449

Closed
wants to merge 1 commit into from
Closed

tools: fix test.py --shell #26449

wants to merge 1 commit into from

Conversation

hashseed
Copy link
Member

@hashseed hashseed commented Mar 5, 2019

This fixes the necessary plumbing to make the --shell argument
have its intended effect.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Mar 5, 2019
tools/test.py Outdated Show resolved Hide resolved
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍
I have this TODO written down in 5 separate places

@refack refack added the python PRs and issues that require attention from people who are familiar with Python. label Mar 5, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 5, 2019

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2019
This fixes the necessary plumbing to make the --shell argument
have its intended effect.
@hashseed
Copy link
Member Author

hashseed commented Mar 6, 2019

Started a new CI after fixing the nit: https://ci.nodejs.org/job/node-test-pull-request/21249/

danbev pushed a commit to danbev/node that referenced this pull request Mar 8, 2019
This fixes the necessary plumbing to make the --shell argument
have its intended effect.

PR-URL: nodejs#26449
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@danbev
Copy link
Contributor

danbev commented Mar 8, 2019

Landed in ede1a7c.

@danbev danbev closed this Mar 8, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
This fixes the necessary plumbing to make the --shell argument
have its intended effect.

PR-URL: nodejs#26449
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
This fixes the necessary plumbing to make the --shell argument
have its intended effect.

PR-URL: #26449
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
This fixes the necessary plumbing to make the --shell argument
have its intended effect.

PR-URL: #26449
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants