Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: revise Collaborator Guide on reverting #25942

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 5, 2019

Revise the "Reverting commits" section of the Collaborator Guide. Reduce
passive voice. Increase clarity.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 5, 2019
Revise the "Reverting commits" section of the Collaborator Guide. Reduce
passive voice. Increase clarity.
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 5, 2019
@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Feb 5, 2019
@Trott
Copy link
Member Author

Trott commented Feb 7, 2019

Landed in cf43846

@Trott Trott closed this Feb 7, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 7, 2019
Revise the "Reverting commits" section of the Collaborator Guide. Reduce
passive voice. Increase clarity.

PR-URL: nodejs#25942
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 7, 2019
Revise the "Reverting commits" section of the Collaborator Guide. Reduce
passive voice. Increase clarity.

PR-URL: #25942
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
@Trott Trott deleted the not-so-passive branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants