Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-trace-events-fs-sync as FLAKY #25899

Closed
wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Feb 2, 2019

Refs: #25512

Flake frequency ebbs and flows but it's still a pain.
Marking as FLAKY until we solve the underling issue.

/CC @nodejs/testing @gireeshpunathil @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 2, 2019
@refack refack requested a review from Trott February 2, 2019 17:55
@refack refack added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 2, 2019
@refack
Copy link
Contributor Author

refack commented Feb 2, 2019

I'd like to fast track this. Please 👍 if you concur.

@addaleax
Copy link
Member

addaleax commented Feb 2, 2019

Marking as FLAKY until we solve the underling issue.

We also have the option of fast-tracking #25896 if you think there is urgency to resolve this? It's not a complex change, so I think this should be okay.

@addaleax
Copy link
Member

addaleax commented Feb 2, 2019

If you do want to merge this, please add a reference to #25512 in the commit message.

@refack
Copy link
Contributor Author

refack commented Feb 2, 2019

We also have the option of fast-tracking #25896 if you think there is urgency to resolve this? It's not a complex change, so I think this should be okay.

I'll verify that it solves the issue in a environment known to repro.

If you do want to merge this, please add a reference to #25512 in the commit message.

👍 with the magic of node-core-utils, it adds the Refs from the OP to the final commit message without getting all the
image
during review.

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although obviously even better if the proposed solution works and we don't have to mark this as flaky at all.

@refack
Copy link
Contributor Author

refack commented Feb 2, 2019

Superseded by #25896

@refack refack closed this Feb 2, 2019
@refack refack deleted the flaky-test-trace-events-fs-sync branch February 2, 2019 23:52
@refack refack restored the flaky-test-trace-events-fs-sync branch February 3, 2019 16:10
@refack refack removed the superseded label Feb 3, 2019
@refack
Copy link
Contributor Author

refack commented Feb 3, 2019

Reopening since #25896 seems to be taking longer. Please 👍 for FT.

@refack refack self-assigned this Feb 3, 2019
@refack refack reopened this Feb 3, 2019
@refack
Copy link
Contributor Author

refack commented Feb 3, 2019

@refack
Copy link
Contributor Author

refack commented Feb 4, 2019

Superseded by #25896

@refack refack closed this Feb 4, 2019
@refack refack deleted the flaky-test-trace-events-fs-sync branch February 15, 2019 00:20
@refack refack removed their assignment Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants