src: use visibility("default") for exports on POSIX
#25893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Electron uses this because Chromium builds with symbols hidden by default. Refs: electron/node@88b4941 Refs: electron/node@1293d1d
nodejs-github-bot
added
the
c++
cjihrig
approved these changes
Feb 2, 2019
targos
reviewed
Feb 2, 2019
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20542/ (✔️) |
addaleax
added
the
author ready
gengjiawen
approved these changes
Feb 2, 2019
|
Landed in 1ac6ea2. |
danbev
pushed a commit
that referenced
this pull request
Feb 5, 2019
Electron uses this because Chromium builds with symbols hidden by default. Refs:https://github.com/electron/node/commit/ 88b4941 Refs: https://github.com/electron/node/commit/ 1293d1d7d0c33d3925da11ceccdce4eb2e927a43 PR-URL: #25893 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 6, 2019
Electron uses this because Chromium builds with symbols hidden by default. Refs:https://github.com/electron/node/commit/ 88b4941 Refs: https://github.com/electron/node/commit/ 1293d1d7d0c33d3925da11ceccdce4eb2e927a43 PR-URL: #25893 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron uses this because Chromium builds with symbols
hidden by default.
Refs: electron/node@88b4941
Refs: electron/node@1293d1d
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes