Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 5.13.0 and replace deprecated configuration #25877

Closed
wants to merge 3 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 1, 2019

First commit: Update the eslint-update script to use a newer version of dmn so it will omit .ts and .map files.

Second commit: Update ESLint to 5.13.0.

Third commit: Replace deprecated configuration.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 1, 2019
@Trott Trott changed the title tools: update ESLint to 5.13.0 tools: update ESLint to 5.13.0 and replace deprecated configuration Feb 1, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2019
Version 2.1.0 of dmn will get rid of .map and .ts files.
For `globals`, booleans are deprecated in favor strings
`'readable'`/`'writeable'`.
@Trott
Copy link
Member Author

Trott commented Feb 4, 2019

Landed in 363ef3f...46af4c1

@Trott Trott closed this Feb 4, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 4, 2019
Version 2.1.0 of dmn will get rid of .map and .ts files.

PR-URL: nodejs#25877
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Feb 4, 2019
PR-URL: nodejs#25877
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Feb 4, 2019
For `globals`, booleans are deprecated in favor strings
`'readable'`/`'writeable'`.

PR-URL: nodejs#25877
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@addaleax
Copy link
Member

addaleax commented Feb 6, 2019

Should this be backported to v11.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@Trott
Copy link
Member Author

Trott commented Feb 6, 2019

@addaleax Backported in #25965

addaleax pushed a commit that referenced this pull request Feb 7, 2019
Version 2.1.0 of dmn will get rid of .map and .ts files.

Backport-PR-URL: #25965
PR-URL: #25877
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 7, 2019
Backport-PR-URL: #25965
PR-URL: #25877
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 7, 2019
For `globals`, booleans are deprecated in favor strings
`'readable'`/`'writeable'`.

Backport-PR-URL: #25965
PR-URL: #25877
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants