Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: relax expectations in test-icu-transcode #25866

Closed
wants to merge 1 commit into from

Conversation

hashseed
Copy link
Member

@hashseed hashseed commented Feb 1, 2019

Chromium's ICU considers "latin1" and "ascii" to mean Windows-1252, which is consistent with WHATWG spec. If linked against Chromium's ICU, Node.js therefore fails test/parallel/test-icu-transcode.

Refs: #25851

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 1, 2019
@hashseed hashseed requested a review from srl295 February 1, 2019 12:28
@Trott
Copy link
Member

Trott commented Feb 1, 2019

@nodejs/intl @nodejs/i18n

@addaleax
Copy link
Member

addaleax commented Feb 2, 2019

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 2, 2019
@hashseed
Copy link
Member Author

hashseed commented Feb 4, 2019

Looks again like some Jenkins related issue.

@addaleax
Copy link
Member

addaleax commented Feb 4, 2019

Resume CI again: https://ci.nodejs.org/job/node-test-commit/25596/ (✔️)

@danbev
Copy link
Contributor

danbev commented Feb 5, 2019

Landed in 793c630.

@danbev danbev closed this Feb 5, 2019
danbev pushed a commit that referenced this pull request Feb 5, 2019
Chromium's ICU considers "latin1" and "ascii" to mean Windows-1252,
which is consistent with
[WHATWG spec](https://encoding.spec.whatwg.org/#names-and-labels). If
linked against Chromium's ICU, Node.js therefore fails
`test/parallel/test-icu-transcode`.

PR-URL: #25866
Refs: #25851
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 6, 2019
Chromium's ICU considers "latin1" and "ascii" to mean Windows-1252,
which is consistent with
[WHATWG spec](https://encoding.spec.whatwg.org/#names-and-labels). If
linked against Chromium's ICU, Node.js therefore fails
`test/parallel/test-icu-transcode`.

PR-URL: #25866
Refs: #25851
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
@hashseed hashseed deleted the windows1252 branch February 15, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants