Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: move deprecation warning initialization into pre_execution.js #25825

Closed
wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Since this is only necessary when user code execution is expected.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 30, 2019
@@ -55,6 +56,7 @@ port.on('message', (message) => {
if (manifestSrc) {
require('internal/process/policy').setup(manifestSrc, manifestURL);
}
initializeDeprecations();
initializeClusterIPC();
initializeESMLoader();
loadPreloadModules();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any point in trying to group these 4 or 5 calls into a single one, possibly with an options object that indicates which parts of the setup to run?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried that before but a single call seems to hide too much details - I think it should be fine to directly drop some of the calls, for example, initializeClusterIPC in repl.js. Also the order in which these executes matters to some extent and an option object would blur that.

Maybe we could group them by different modes, but I cannot think of good names for those modes off the top of my head.

Since this is only necessary when user code execution is expected.
@joyeecheung
Copy link
Member Author

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 7, 2019
@joyeecheung
Copy link
Member Author

@joyeecheung
Copy link
Member Author

Landed in 09a5f02

@joyeecheung joyeecheung closed this Feb 8, 2019
joyeecheung added a commit that referenced this pull request Feb 8, 2019
Since this is only necessary when user code execution is expected.

PR-URL: #25825
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Feb 10, 2019
Since this is only necessary when user code execution is expected.

PR-URL: #25825
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants