Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use nullptr in node_buffer.cc #25820

Closed
wants to merge 1 commit into from
Closed

src: use nullptr in node_buffer.cc #25820

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Jan 30, 2019
@addaleax
Copy link
Member

addaleax commented Feb 1, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20531/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2019
@danbev
Copy link
Contributor

danbev commented Feb 4, 2019 •
edited
Loading

Re-build of failing node-test-commit-windows-fanned (✔️)

@danbev
Copy link
Contributor

danbev commented Feb 4, 2019

Landed in 66f08fd.

@danbev danbev closed this Feb 4, 2019
danbev pushed a commit that referenced this pull request Feb 4, 2019
@gengjiawen @danbev
src: use nullptr in node_buffer.cc
66f08fd 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25820
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 6, 2019
@gengjiawen @addaleax
src: use nullptr in node_buffer.cc
00f8e86 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25820
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gengjiawen @addaleax @danbev @jasnell @lpinca @cjihrig @richardlau @nodejs-github-bot