Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: refactor benchmark/common.js #25805

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 29, 2019

Refactor benchmark/common.js to consistently use arrow functions for
anonymous callbacks and trailing commas.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Refactor benchmark/common.js to consistently use arrow functions for
anonymous callbacks and trailing commas.
@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Jan 29, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 30, 2019
@Trott
Copy link
Member Author

Trott commented Jan 30, 2019

@Trott
Copy link
Member Author

Trott commented Jan 30, 2019

Whoops, that was a benchmark CI against master. Here's one against this PR: https://ci.nodejs.org/job/node-test-commit-custom-suites/851/

Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this kind of changes could be done with tools like eslint.

@Trott
Copy link
Member Author

Trott commented Feb 1, 2019

Landed in 7c9fba3

@Trott Trott closed this Feb 1, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 1, 2019
Refactor benchmark/common.js to consistently use arrow functions for
anonymous callbacks and trailing commas.

PR-URL: nodejs#25805
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 1, 2019
Refactor benchmark/common.js to consistently use arrow functions for
anonymous callbacks and trailing commas.

PR-URL: #25805
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
@Trott Trott deleted the benchmark-common branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants