Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: use consistent format for dumpEventTime #25751

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Use the same JS-compatible format on both POSIX and Windows.

Side note: It might be nice to wrap up all the different date-handling pieces of code in a single place, with a single mechanism and using some standardized format(s).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Use the same JS-compatible format on both POSIX and Windows.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 28, 2019
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any idea why it was done like this originally?

@richardlau
Copy link
Member

LGTM. Any idea why it was done like this originally?

No idea. The equivalent code in the standalone module is consistent (both Windows and non-Windows use /): https://github.com/nodejs/node-report/blob/c1cec1322ddcc83b3b80c04d9b043e7e36c4d9c8/src/node_report.cc#L234-L252

@gireeshpunathil
Copy link
Member

Any idea why it was done like this originally?

@cjihrig - no specific reason I can recollect; so may be a slip when I changed many things in succession.

@addaleax
Copy link
Member Author

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2019
@addaleax
Copy link
Member Author

@addaleax
Copy link
Member Author

Landed in 23d51a1

@addaleax addaleax closed this Jan 30, 2019
@addaleax addaleax deleted the report-time branch January 30, 2019 22:39
addaleax added a commit that referenced this pull request Jan 30, 2019
Use the same JS-compatible format on both POSIX and Windows.

PR-URL: #25751
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
addaleax added a commit that referenced this pull request Jan 30, 2019
Use the same JS-compatible format on both POSIX and Windows.

PR-URL: #25751
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants