Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: fix public key encoding name in comment #25736

Closed
wants to merge 1 commit into from

Commits on Jan 27, 2019

  1. crypto: fix public key encoding name in comment

    PKCS#8 describes an encoding for private keys, not public keys. Using
    the name as a format usually refers to the PrivateKeyInfo structure it
    defines. (Or sometimes the EncryptedPrivateKeyInfo variant or the
    little-used OneAsymmetricKey extension defined in RFC 5958.) None of
    these structures can hold public keys to begin with.
    
    d2i_PUBKEY actually parses the public key analogous format defined in
    X.509, SubjectPublicKeyInfo. This function already uses "X.509" to refer
    to an entire certificate, so say SubjectPublicKeyInfo in the comment.
    
    (The abbreviation SPKI sometimes refers to SubjectPublicKeyInfo, e.g. in
    RFC 7469, but it can also an alternate S-expression-based PKI to X.509,
    Simple Public Key Infrastructure. To avoid confusion, stick with the
    expanded name.)
    davidben committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    f65ff6d View commit details
    Browse the repository at this point in the history