Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: Fix malloc mixing in X509ToObject #25717

Closed
wants to merge 2 commits into from
Closed

crypto: Fix malloc mixing in X509ToObject #25717

wants to merge 2 commits into from

Commits on Jan 27, 2019

  1. crypto: fix malloc mixing in X509ToObject 

    EC_KEY_key2buf returns an OPENSSL_malloc'd pointer so it shouldn't be
passed into Buffer::New, which expect a libc malloc'd pointer. Instead,
factor out the ECDH::GetPublicKey code which uses EC_POINT_point2oct.

This preserves the existing behavior where encoding failures are
silently ignored, but it is probably safe to CHECK fail them instead.
    @davidben
    davidben committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    9110ab3 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. Use MaybeLocal::ToLocal and don't crash X509ToObject on error.

    @davidben
    davidben committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    eb7748b View commit details
    Browse the repository at this point in the history