doc: add metadata to report docs #25708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
vsemozhetbyt
approved these changes
Jan 25, 2019
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
cjihrig
approved these changes
Jan 25, 2019
vsemozhetbyt
added
the
author ready
addaleax
approved these changes
Jan 25, 2019
|
Landed in f40778e |
addaleax
pushed a commit
that referenced
this pull request
Jan 25, 2019
Fixes: #25682 PR-URL: #25708 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jan 28, 2019
Fixes: #25682 PR-URL: #25708 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25682
I based the metadata based on the other files in
doc/(we don't seem to have much (any?) documentation on what metadata should be included).cc @nodejs/documentation
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes