Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix sequential/test-performance delay #25695

Closed
wants to merge 1 commit into from
Closed

test: fix sequential/test-performance delay #25695

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

@apapirovski apapirovski commented Jan 25, 2019 •
edited
Loading

This should resolve the flakiness on this test on slower systems where the inited time we store in JS can be much later than the nodeTiming one.

Fixes: #23291

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@apapirovski build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2382/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 25, 2019
@Trott
Copy link
Member

Trott commented Jan 25, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20317/ ✅

TimothyGu
TimothyGu approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some… quite slow machines. But LGTM, if they are confirmed to fix the flakiness to a satisfactory level.

@Trott Trott mentioned this pull request Jan 25, 2019
Closed
@Trott
Copy link
Member

Trott commented Jan 25, 2019

These are some… quite slow machines.

Indeed a Raspberry Pi can have as little as 256 Mb of RAM and a 700 MHz processor. Not sure if that's the spec for these machines, but it certainly gives you the idea.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 25, 2019
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 25, 2019
@Trott
Copy link
Member

Trott commented Jan 25, 2019

Please 👍 here to approve fast-tracking to unbreak CI.

@Trott
Copy link
Member

Trott commented Jan 26, 2019

Landed in d1d357d

@Trott Trott closed this Jan 26, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 26, 2019
@apapirovski @Trott
test: fix sequential/test-performance delay
d1d357d 
PR-URL: nodejs#25695
Fixes: nodejs#23291
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@gireeshpunathil gireeshpunathil mentioned this pull request Jan 26, 2019
Closed
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@apapirovski @addaleax
test: fix sequential/test-performance delay
f33d705 
PR-URL: #25695
Fixes: #23291
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@targos targos mentioned this pull request Jan 29, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@apapirovski @BethGriggs
test: fix sequential/test-performance delay
d744de4 
PR-URL: #25695
Fixes: #23291
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@apapirovski @BethGriggs
test: fix sequential/test-performance delay
3f0bc59 
PR-URL: #25695
Fixes: #23291
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@apapirovski @MylesBorins
test: fix sequential/test-performance delay
301f5fb 
PR-URL: #25695
Fixes: #23291
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky sequential/test-performance
6 participants
@apapirovski @nodejs-github-bot @Trott @Fishrock123 @TimothyGu @cjihrig