doc: clarify what dns.setResolvers() affects #25570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dns
sam-github
force-pushed
the
doc-clarify-setservers
branch
from
5a91f8d
to
ccec12a
Compare
vsemozhetbyt
approved these changes
Jan 18, 2019
| The `dns.setServers()` method affects only the methods of [`dns.Resolver`][] | ||
| that have equivalents as `dns.*()` APIs (and specifically *not* | ||
| [`dns.lookup()`][]). It must not be called while those methods are in progress. | ||
|
|
There was a problem hiding this comment.
Nit: unneeded empty line?
szmarczak
reviewed
Jan 18, 2019
lpinca
approved these changes
Jan 18, 2019
szmarczak
approved these changes
Jan 18, 2019
addaleax
reviewed
Jan 18, 2019
sam-github
force-pushed
the
doc-clarify-setservers
branch
from
ccec12a
to
905a392
Compare
I haven't changed this text, and don't want to get into it here. I'll add it to my todo list. Can you reference the PR that did this? It'll need YAML change markers. If you don't know, I'll track it down some time. The structure of the docs are confusing. The Resolver class refers to the global docs, but it really be the other way around, the Resolver methods should be documented, and the globals should state that there is a global Resolver. An astute reader could guess that its implemented like this, but it isn't clearly stated. |
It does not affect dns.lookup().
sam-github
force-pushed
the
doc-clarify-setservers
branch
from
905a392
to
d003bcd
Compare
|
Landed in 0ce615c |
pull bot
pushed a commit
to zys-contrib/node
that referenced
this pull request
Jan 25, 2019
It does not affect dns.lookup(). PR-URL: nodejs#25570 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jan 28, 2019
It does not affect dns.lookup(). PR-URL: #25570 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 29, 2019
It does not affect dns.lookup(). PR-URL: #25570 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
It does not affect dns.lookup(). PR-URL: #25570 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
It does not affect dns.lookup(). PR-URL: #25570 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not affect dns.lookup().
cf. #25560
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes