Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: fix key handle extraction #25562

Closed

Conversation

tniessen
Copy link
Member

I guess I don't need to say much about the commit itself. This causes the crash described in a comment in #25217, so it would be awesome if this could make it into 11.7.0 somehow, cc @BridgeAR.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the crypto Issues and PRs related to the crypto subsystem. label Jan 18, 2019
@tniessen
Copy link
Member Author

Node.js collaborators, please 👍 here to approve fast-tracking.

@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 18, 2019
@BridgeAR
Copy link
Member

Landed in 9315daa 🎉

@BridgeAR BridgeAR closed this Jan 18, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 18, 2019
PR-URL: nodejs#25562
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 23, 2019
PR-URL: #25562
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants