doc: fs.mkdir('/') throws EPERM on Windows #25340
Conversation
nodejs-github-bot
added
doc
There was a problem hiding this comment.
Hi, @coreyfarrell! Welcome and thanks for the pull request.
I've left a comment with a requested change. It wraps the text at 80 characters, which you should have received an error about if you ran make lint-md (fast) or make test (slow). It also changes the wording, adds punctuation, and styling. Please take a look.
|
@MylesBorins This documentation update is intended for v10.x and v11.x in addition to master. I assume you don't want me to open PR's for each branch but please let me know if I need to take additional actions or how to handle situations like this in the future. |
Someone will cherry-pick the commit to the other branches. If the cherry-pick does not work because of a conflict, they may leave a comment here asking you to open a backport PR. There's nothing to do at this time, though. |
There was a problem hiding this comment.
thanks for adding this note @coreyfarrell take or leave my comma preferences.
| @@ -2212,6 +2212,15 @@ fs.mkdir('/tmp/a/apple', { recursive: true }, (err) => { | |||
| }); | |||
| ``` | |||
|
|
|||
| On Windows, using `fs.mkdir()` on the root directory even with recursion will | |||
There was a problem hiding this comment.
the nit picky editor in me wonders whether this should be:
Using `fs.mkdir()` on the root directory, even with recursion, will
result in an error on Windows:
There was a problem hiding this comment.
My preference is for the fact that it's platform specific to be first but I'm willing to do whatever the consensus is.
There was a problem hiding this comment.
This maybe?
On Windows, using `fs.mkdir()` on the root directory, even with recursion, will
result in an error:
bcoe
added
the
author ready
Fixes: #25110 PR-URL: #25340 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Coe <[email protected]>
|
Landed in e7c6f4f |
|
@coreyfarrell congrats on your first contribution to Node.js 🎉 |
Fixes: #25110 PR-URL: #25340 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Coe <[email protected]>
Fixes: nodejs#25110 PR-URL: nodejs#25340 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Coe <[email protected]>
Fixes: nodejs#25110 PR-URL: nodejs#25340 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Coe <[email protected]>
Fixes: #25110 PR-URL: #25340 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Coe <[email protected]>
Fixes: #25110 PR-URL: #25340 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Coe <[email protected]>
Fixes: #25110 PR-URL: #25340 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Coe <[email protected]>
Fixes: #25110
Checklist
CC @bcoe @nodejs/fs