Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fixing the path to postMessage #25332

Closed
wants to merge 1 commit into from
Closed

doc: fixing the path to postMessage #25332

wants to merge 1 commit into from

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Jan 3, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 3, 2019
addaleax
addaleax approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you wrap this line at 80 characters?

@addaleax addaleax added the worker Issues and PRs related to Worker support. label Jan 7, 2019
@mitar
Copy link
Contributor Author

mitar commented Jan 8, 2019

Done.

@addaleax
Copy link
Member

addaleax commented Jan 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2170/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 8, 2019
@addaleax
Copy link
Member

addaleax commented Jan 8, 2019

Oh, I think the linter in Travis is failing because the link definition should also be changed?

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 8, 2019
@mitar
Copy link
Contributor Author

mitar commented Jan 8, 2019

You are right. This is anchor link or something.

@mitar
Copy link
Contributor Author

mitar commented Jan 8, 2019

I think I fixed it now.

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2236/

@vsemozhetbyt
Copy link
Contributor

Landed in 56e7a7c
Thank you!

pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Jan 11, 2019
@mitar @vsemozhetbyt
doc: fix the path to postMessage()
56e7a7c 
PR-URL: nodejs#25332
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@mitar @addaleax
doc: fix the path to postMessage()
ebd2027 
PR-URL: #25332
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@mitar @BridgeAR
doc: fix the path to postMessage()
13a38bd 
PR-URL: nodejs#25332
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@mitar @BethGriggs
doc: fix the path to postMessage()
26e6a24 
PR-URL: #25332
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@mitar @BethGriggs
doc: fix the path to postMessage()
c1a47fd 
PR-URL: #25332
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@mitar @MylesBorins
doc: fix the path to postMessage()
8f0fa61 
PR-URL: #25332
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
This was referenced May 29, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mitar @addaleax @vsemozhetbyt @jasnell @nodejs-github-bot