Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: use engine-provided deleter for SharedArrayBuffers #25307

Closed
wants to merge 3 commits into from
Closed

worker: use engine-provided deleter for SharedArrayBuffers #25307

wants to merge 3 commits into from

Commits on Jan 1, 2019

  1. worker: use engine-provided deleter for SharedArrayBuffers 

    Store the full information we have on a given `SharedArrayBuffer`,
and use the deleter provided by the JS engine to free the memory
when that is needed.

This fixes memory lifetime management for WASM buffers that are
passed through a `MessageChannel` (e.g. between threads).
    @addaleax
    addaleax committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    5bebab1 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2019

  1. fixup! worker: use engine-provided deleter for SharedArrayBuffers

    @addaleax
    addaleax committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    c6dbe1a View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. fixup! fixup! worker: use engine-provided deleter for `SharedArrayBuf… 

    …fer`s
    @addaleax
    addaleax committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    c35ec27 View commit details
    Browse the repository at this point in the history