Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary test flags #25277

Merged
merged 1 commit into from
Jan 1, 2019
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 29, 2018

This commit removes unnecessary flags used when starting tests via the "// Flags:" directive.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 29, 2018
@@ -1,4 +1,3 @@
// Flags: --pending-deprecation --no-warnings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the same flags in test-buffer-of-no-deprecation be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you.

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 31, 2018

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 31, 2018
This commit removes unnecessary flags used when starting
tests via the "// Flags:" directive.

PR-URL: nodejs#25277
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@cjihrig cjihrig merged commit e765847 into nodejs:master Jan 1, 2019
@cjihrig cjihrig deleted the extra-flags branch January 1, 2019 15:00
addaleax pushed a commit that referenced this pull request Jan 5, 2019
This commit removes unnecessary flags used when starting
tests via the "// Flags:" directive.

PR-URL: #25277
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
This commit removes unnecessary flags used when starting
tests via the "// Flags:" directive.

PR-URL: nodejs#25277
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
This commit removes unnecessary flags used when starting
tests via the "// Flags:" directive.

PR-URL: nodejs#25277
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants