Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: cleanup util #25255

Closed
wants to merge 5 commits into from
Closed

util: cleanup util #25255

wants to merge 5 commits into from

Commits on Dec 28, 2018

  1. util: switch recurseTimes counter 

    This makes sure the counter goes up instead of going down. This allows
to properly track the current inspection depth no matter what the
`depth` option was set to.
    @BridgeAR
    BridgeAR committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    17aa99f View commit details
    Browse the repository at this point in the history

  2. util: code cleanup 

    Remove some dead code plus some minor refactoring for readability.
The constructor can not be an empty string anymore, so just remove
that check.
    @BridgeAR
    BridgeAR committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    e73a36c View commit details
    Browse the repository at this point in the history

  3. util: simpler module namespace code 

    This removes a special casing for this data type in the main function.
    @BridgeAR
    BridgeAR committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    65cad90 View commit details
    Browse the repository at this point in the history

  4. util: remove outdated comment 

    This comment is not correct anymore.
    @BridgeAR
    BridgeAR committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    057882e View commit details
    Browse the repository at this point in the history

  5. util: remove eslint comments and rename variables 

    This should improve the readability of the code.
    @BridgeAR
    BridgeAR committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    669c2f4 View commit details
    Browse the repository at this point in the history