[v8.x] update the http.request.setTimeout docs to be accurate #25123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message:
[cpu-profiler] Fix a leak caused by re-logging existing functions.
Don't re-log all existing functions during StartProcessorIfNotStarted().
They will already be in the CodeMap attached to the ProfileGenerator and
re-logging them causes leaks. See the linked bug for more details.
Bug: v8:8253
Change-Id: Ibb1a1ab2431c588e8c3a3a9ff714767cdf61a88e
Reviewed-on: https://chromium-review.googlesource.com/1256763
Commit-Queue: Peter Marshall <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#56336}
Refs: v8/v8@525b396
PR-URL: nodejs#25041
Reviewed-By: Yang Guo <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
nodejs-github-bot
added
doc
This was referenced Dec 19, 2018
lpinca
reviewed
Dec 19, 2018
jbunton-atlassian
force-pushed
the
update_v8.x_docs_for_http_request_setTimeout
branch
from
6c16983
to
544e913
Compare
lpinca
approved these changes
Dec 19, 2018
jbunton-atlassian
force-pushed
the
update_v8.x_docs_for_http_request_setTimeout
branch
3 times, most recently
from
b1d62ee
to
44d5c9a
Compare
jasnell
reviewed
Dec 19, 2018
jbunton-atlassian
force-pushed
the
update_v8.x_docs_for_http_request_setTimeout
branch
from
44d5c9a
to
fc173b3
Compare
jasnell
approved these changes
Dec 20, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2018
Refs: #8895 PR-URL: #25123 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
changed the title
MylesBorins
force-pushed
the
v8.x-staging
branch
from
c5142b3
to
3af7528
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
Refs: #8895 PR-URL: #25123 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
landed in 3af7528 |
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Refs: #8895 PR-URL: #25123 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading from Node.js 8 to 10 I hit the behaviour change in #8895. This documentation update would have helped me find the problem faster :)
Also see #25121 for an update to the docs on master.
Thanks :)
Checklist