Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: fix spread operator #25101

Closed
wants to merge 3 commits into from
Closed

deps: V8: fix spread operator #25101

wants to merge 3 commits into from

Commits on Dec 20, 2018

  1. deps: patch V8 to 7.1.302.33 

    Refs: v8/v8@7.1.302.28...7.1.302.33
    @BridgeAR
    BridgeAR committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    c9bbf5a View commit details
    Browse the repository at this point in the history

  2. deps: V8: backport bf84766 

    Original commit message:

    [CloneObjectIC] clone MutableHeapNumbers instead of referencing them

    Adds a helper macro "CloneIfMutablePrimitive", which tests if the
    operand is a MutableHeapNumber, and if so, clones it, otherwise
    returning the original value.

    Also modifies the signature of "CopyPropertyArrayValues" to take a
    "DestroySource" enum, indicating whether or not the resulting object is
    supplanting the source object or not, and removes all default
    parameters from that macro (which were not used anyways).

    This corrects the issue reported in chromium:901301, where
    StaNamedOwnProperty was replacing the value of a MutableHeapNumber
    referenced by both the cloned object and the source object.

    BUG=chromium:901301, v8:7611
    [email protected], [email protected]

    Change-Id: I43df1ddc84dfa4840e680b6affeba452ce0b6629
    Reviewed-on: https://chromium-review.googlesource.com/c/1318096
    Commit-Queue: Caitlin Potter <[email protected]>
    Reviewed-by: Jakob Kummerow <[email protected]>
    Reviewed-by: Camillo Bruni <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#57304}

Refs: v8/v8@bf84766
    @BridgeAR
    BridgeAR committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    feba312 View commit details
    Browse the repository at this point in the history

  3. deps: V8: backport 3e010af 

    Original commit message:

    [CloneObjectIC] clone MutableHeapNumbers only if !FLAG_unbox_double_fields

    Change the macros added in bf84766a2cd3e09070adcd6228a3a487c8dc4bbd to
    only do the hard work if FLAG_unbox_double_fields is unset (otherwise,
    they will attempt to dereference raw float64s, which is bad!)

    Also adds a write barrier in CopyPropertyArrayValues for each store if
    it's possible that a MutableHeapNumber is cloned.

    BUG=chromium:901301, chromium:902965, chromium:903070, v8:7611
    [email protected], [email protected], [email protected]

    Change-Id: I224d3c4e7b0a887684bff68985b4d97021ba4cfb
    Reviewed-on: https://chromium-review.googlesource.com/c/1323911
    Commit-Queue: Caitlin Potter <[email protected]>
    Reviewed-by: Camillo Bruni <[email protected]>
    Reviewed-by: Igor Sheludko <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#57368}

Refs: v8/v8@3e010af
    @BridgeAR
    BridgeAR committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    6096720 View commit details
    Browse the repository at this point in the history