Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: move POSIX credential accessors into node_credentials.cc #25066

Closed
wants to merge 1 commit into from

Commits on Dec 18, 2018

  1. process: move POSIX credential accessors into node_credentials.cc

    Expose the POSIX credential accessors through
    `internalBinding('credentials')` instead of setting them on the
    process or bootstrapper object from C++ directly. Also moves
    `SafeGetEnv` from `internalBinding('util')` to
    `internalBinding('credentials')` since it's closely related to
    the credentials.
    
    In the JS land, instead of wrapping the bindings then writing
    to the process object directly in main_thread_only.js, return
    the wrapped functions back to bootstrap/node.js where they get
    written to the process object conditionally for clarity.
    
    Refs: nodejs#24961
    joyeecheung committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    39da0cc View commit details
    Browse the repository at this point in the history