test: remove dead code #25009
Closed
test: remove dead code #25009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not used by the test anymore.
This removes two entries from the eslint ignore file. One file does not exist anymore and the other one could easily be fixed.
BridgeAR
commented
Dec 13, 2018
| @@ -1,9 +1,7 @@ | |||
| node_modules | |||
| lib/internal/v8.js | |||
| lib/internal/v8_prof_polyfill.js | |||
There was a problem hiding this comment.
I am not sure what this file does. Do we have to ignore the file here?
There was a problem hiding this comment.
My vague recollection: I think the file was originally copied from either V8 source or a V8 change proposal that may have been rejected by V8. Since we were copying the file, we didn't apply our lint style to it since we would just copy changes from upstream at a later date, presumably. This is similar, I think, to how we handle punycode.js. It looks like we may now basically own v8_prof_polyfill.js, though. I'm not sure. @matthewloring may know,.
thefourtheye
approved these changes
Dec 13, 2018
BridgeAR
added
the
author ready
Trott
approved these changes
Dec 13, 2018
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 15, 2018
This is not used by the test anymore. PR-URL: nodejs#25009 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 15, 2018
This removes two entries from the eslint ignore file. One file does not exist anymore and the other one could easily be fixed. PR-URL: nodejs#25009 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in e7c3a1b...1395256 |
BethGriggs
pushed a commit
that referenced
this pull request
Dec 18, 2018
This is not used by the test anymore. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 18, 2018
This removes two entries from the eslint ignore file. One file does not exist anymore and the other one could easily be fixed. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This is not used by the test anymore. PR-URL: nodejs#25009 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This removes two entries from the eslint ignore file. One file does not exist anymore and the other one could easily be fixed. PR-URL: nodejs#25009 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
This is not used by the test anymore. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
This removes two entries from the eslint ignore file. One file does not exist anymore and the other one could easily be fixed. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
This is not used by the test anymore. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
This removes two entries from the eslint ignore file. One file does not exist anymore and the other one could easily be fixed. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
This is not used by the test anymore. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
This removes two entries from the eslint ignore file. One file does not exist anymore and the other one could easily be fixed. PR-URL: #25009 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not used by the test anymore.
I am uncertain why this is not found by eslint but I did not check.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes