Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

querystring: remove eslint-disable #24995

Merged
merged 2 commits into from
Dec 14, 2018
Merged

querystring: remove eslint-disable #24995

merged 2 commits into from
Dec 14, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 12, 2018

Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the querystring Issues and PRs related to the built-in querystring module. label Dec 12, 2018
@Trott
Copy link
Member

Trott commented Dec 12, 2018

Is this worth benchmarking?

@targos
Copy link
Member

targos commented Dec 12, 2018

I'd say no. Performance can only be improved by this change

@antsmartian antsmartian added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2018
@Trott
Copy link
Member

Trott commented Dec 14, 2018

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 14, 2018

Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

PR-URL: nodejs#24995
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.

PR-URL: nodejs#24995
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@cjihrig cjihrig merged commit 8ac6c05 into nodejs:master Dec 14, 2018
@cjihrig cjihrig deleted the lint branch December 14, 2018 18:16
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

PR-URL: nodejs#24995
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.

PR-URL: nodejs#24995
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
MylesBorins pushed a commit that referenced this pull request May 16, 2019
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

PR-URL: #24995
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. querystring Issues and PRs related to the built-in querystring module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants