-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add authority and scheme psuedo headers #24777
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request adds the request psuedo headers authority and scheme to the http2 documentation Fixes: nodejs#23825
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
http2
Issues or PRs related to the http2 subsystem.
labels
Dec 2, 2018
Trott
reviewed
Dec 2, 2018
Trott
reviewed
Dec 2, 2018
@nodejs/http2 |
vsemozhetbyt
reviewed
Dec 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Just some nits.
@vsemozhetbyt Thanks. Made the adjustments accordingly |
addaleax
approved these changes
Dec 4, 2018
danbev
approved these changes
Dec 5, 2018
vsemozhetbyt
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Dec 5, 2018
Landed in bb01597 |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Dec 5, 2018
This pull request adds the request psuedo headers authority and scheme to the http2 documentation PR-URL: #24777 Fixes: #23825 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 6, 2018
This pull request adds the request psuedo headers authority and scheme to the http2 documentation PR-URL: #24777 Fixes: #23825 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 7, 2018
This pull request adds the request psuedo headers authority and scheme to the http2 documentation PR-URL: #24777 Fixes: #23825 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 7, 2018
This pull request adds the request psuedo headers authority and scheme to the http2 documentation PR-URL: #24777 Fixes: #23825 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This pull request adds the request psuedo headers authority and scheme to the http2 documentation PR-URL: nodejs#24777 Fixes: nodejs#23825 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
This pull request adds the request psuedo headers authority and scheme to the http2 documentation PR-URL: #24777 Fixes: #23825 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
This pull request adds the request psuedo headers authority and scheme to the http2 documentation PR-URL: #24777 Fixes: #23825 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
This pull request adds the request psuedo headers authority and scheme to the http2 documentation PR-URL: #24777 Fixes: #23825 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
http2
Issues or PRs related to the http2 subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc: add authority and scheme psuedo headers to http2.md
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation
Fixes: #23825
Checklist