Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add authority and scheme psuedo headers #24777

Closed
wants to merge 3 commits into from

Conversation

kenigbolo
Copy link
Contributor

doc: add authority and scheme psuedo headers to http2.md

This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

Fixes: #23825

Checklist
  • documentation is changed or added
  • commit message follows [commit guidelines]

This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

Fixes: nodejs#23825
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Dec 2, 2018
doc/api/http2.md Outdated Show resolved Hide resolved
doc/api/http2.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Dec 2, 2018

@nodejs/http2

Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just some nits.

doc/api/http2.md Outdated Show resolved Hide resolved
doc/api/http2.md Outdated Show resolved Hide resolved
doc/api/http2.md Outdated Show resolved Hide resolved
doc/api/http2.md Outdated Show resolved Hide resolved
@kenigbolo
Copy link
Contributor Author

@vsemozhetbyt Thanks. Made the adjustments accordingly

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2018
@vsemozhetbyt
Copy link
Contributor

Landed in bb01597
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Dec 5, 2018
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: #24777
Fixes: #23825
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 6, 2018
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: #24777
Fixes: #23825
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 6, 2018
4 tasks
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: #24777
Fixes: #23825
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: #24777
Fixes: #23825
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: nodejs#24777
Fixes: nodejs#23825
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: #24777
Fixes: #23825
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: #24777
Fixes: #23825
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
This pull request adds the request psuedo headers authority
and scheme to the http2 documentation

PR-URL: #24777
Fixes: #23825
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for Http2ServerRequest properties
6 participants