-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v10.x backport] doc: sort bottom-of-file markdown links #24681
Closed
sam-github
wants to merge
1
commit into
nodejs:v10.x-staging
from
sam-github:backport-24679-to-v10.x
Closed
[v10.x backport] doc: sort bottom-of-file markdown links #24681
sam-github
wants to merge
1
commit into
nodejs:v10.x-staging
from
sam-github:backport-24679-to-v10.x
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sam-github sadly an error occured when I tried to trigger a build :( |
This was referenced Nov 27, 2018
Does this need rebasing? |
sam-github
force-pushed
the
backport-24679-to-v10.x
branch
from
November 28, 2018 17:16
f7d96c0
to
fee088e
Compare
This change cherry-picked clean to the head of v10.x-staging, and I repushed. |
vsemozhetbyt
approved these changes
Nov 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a nit.
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
MylesBorins
force-pushed
the
v10.x-staging
branch
from
November 29, 2018 16:40
bda1cc7
to
6936060
Compare
sam-github
force-pushed
the
backport-24679-to-v10.x
branch
2 times, most recently
from
November 30, 2018 22:31
fcaef9b
to
eb5b537
Compare
MylesBorins
force-pushed
the
v10.x-staging
branch
from
December 3, 2018 18:33
4864cb0
to
4035ca1
Compare
sam-github
force-pushed
the
backport-24679-to-v10.x
branch
from
December 3, 2018 22:02
54f9111
to
c3bd8e1
Compare
sam-github
force-pushed
the
backport-24679-to-v10.x
branch
from
December 17, 2018 19:13
c3bd8e1
to
1f22d97
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2018
Reapply #12726 It would be nice to have the sort check applied as part of doc testing, but this change doesn't implement that. Backport-PR-URL: #24681 PR-URL: #24679 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
landed in a5727ff |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
Reapply #12726 It would be nice to have the sort check applied as part of doc testing, but this change doesn't implement that. Backport-PR-URL: #24681 PR-URL: #24679 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #24679
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes